This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC] Add watchpoint hit address function to procfs.c
- From: Pedro Alves <pedro at codesourcery dot com>
- To: "Pierre Muller" <pierre dot muller at ics-cnrs dot unistra dot fr>
- Cc: "'Joel Brobecker'" <brobecker at adacore dot com>, gdb-patches at sourceware dot org
- Date: Mon, 10 May 2010 22:49:20 +0100
- Subject: Re: [RFC] Add watchpoint hit address function to procfs.c
- References: <006601cae54b$368452f0$a38cf8d0$@muller@ics-cnrs.unistra.fr> <201005102027.10080.pedro@codesourcery.com> <001801caf088$4d8a7ae0$e89f70a0$@muller@ics-cnrs.unistra.fr>
On Monday 10 May 2010 22:32:33, Pierre Muller wrote:
> Those failure are a problem within the watchthreads.exp
> source, the test uses '\r' patterns without the '\n' as is usual...
> If I replace all '\r' by '\r+' then there are no failures left
> for that test.
> I ran again both versions (with TIDGET or plain zero)
> and got exactly the same output for both. Thus, apparently the
> thread number is not necessary to get the location of the
> watchpoint even if it is not in the main thread (for my OpenSolaris version
> at least...)
Okay, thanks for taking the trouble to confirm this. Since it was
working before, let's drop that change for now. I don't want to
change things we don't exactly understand, as we may be breaking
something else. If we ever figure out why watchpoints in non-main
threads work as is, we should add a comment explaining it.
--
Pedro Alves