This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[commit/Ada] remove unused variable.


Hello,

Michael pointed out that one of the functions in ada-lang was unused,
and it wasn't obvious to him what the intent was.  It's not obvious
indeed, and I'm not 100% sure whether we meant to cleanup values or not,
but as far as I can tell, we are not creating temporary values in
this case.

I just deleted the variable for now, reran the testsuite JIC, and
committed the following patch.

2010-05-07  Joel Brobecker  <brobecker@adacore.com>

        * ada-lang.c (assign_aggregate): Remove unused variable.

-- 
Joel
Index: ada-lang.c
===================================================================
RCS file: /cvs/src/src/gdb/ada-lang.c,v
retrieving revision 1.260
diff -u -u -p -r1.260 ada-lang.c
--- ada-lang.c	6 May 2010 23:36:39 -0000	1.260
+++ ada-lang.c	7 May 2010 15:59:52 -0000
@@ -8049,7 +8049,6 @@ assign_aggregate (struct value *containe
   int max_indices, num_indices;
   int is_array_aggregate;
   int i;
-  struct value *mark = value_mark ();
 
   *pos += 3;
   if (noside != EVAL_NORMAL)

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]