This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [python][patch] Add GDB Parameters functionality
> Date: Mon, 26 Apr 2010 14:19:21 +0100
> From: Phil Muldoon <pmuldoon@redhat.com>
>
> Thanks, I've made the changes. I would like you to have another look
> at them.
See below.
> > Maybe we should consider mentioning this in NEWS.
>
>
> I thought I attached this to the original patch.
Indeed, you did. Sorry that I missed it. It is okay.
> +Parameters are exposed to the user via the @code{set} and
> +@code{show} commands. @xref{Help}.
^^
Two spaces, please.
> +@item PARAM_STRING
> +The value is a string. When the user modifies the string, any escapes
> +sequences are translated and encoded by @value{GDBN}.
I asked to say something about this translation, or provide an
example.
> +@item PARAM_FILENAME
> +The value is a filename (a string). This value is has to be a valid
> +filename. ^^
The "is" part is probably redundant. Also, what does it mean "a valid
filename"? Does it have to exist, for example? If not, what makes a
file name "invalid"?
Thanks.