This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: [PING] [RFA-v3] Allow explicit 16 or 32 char in 'x /s'
- From: "Pierre Muller" <pierre dot muller at ics-cnrs dot unistra dot fr>
- To: <tromey at redhat dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Thu, 22 Apr 2010 01:22:07 +0200
- Subject: RE: [PING] [RFA-v3] Allow explicit 16 or 32 char in 'x /s'
- References: <11484.4708740295$1268865815@news.gmane.org> <m3mxy5z3j8.fsf@fleche.redhat.com> <83r5ngix6d.fsf@gnu.org> <15103.6087111153$1269298497@news.gmane.org> <m3r5n1v9c0.fsf@fleche.redhat.com> <006101cad0ec$cb7915d0$626b4170$%muller@ics-cnrs.unistra.fr> <83tyrwxy72.fsf@gnu.org> <000f01cad17e$7686f140$6394d3c0$%muller@ics-cnrs.unistra.fr> <83aatnxqhm.fsf@gnu.org> <002701cad513$e44a7420$acdf5c60$%muller@ics-cnrs.unistra.fr> <83fx38xydz.fsf@gnu.org> <001201cad75e$2ef3fcc0$8cdbf640$@muller@ics-cnrs.unistra.fr> <48335.255837492$1271407316@news.gmane.org> <m3sk6o8lqr.fsf@fleche.redhat.com>
> -----Message d'origine-----
> De?: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Tom Tromey
> Envoyé?: Thursday, April 22, 2010 12:49 AM
> À?: Pierre Muller
> Cc?: gdb-patches@sourceware.org; 'Eli Zaretskii'
> Objet?: Re: [PING] [RFA-v3] Allow explicit 16 or 32 char in 'x /s'
>
> >>>>> "Pierre" == Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
> writes:
>
> Pierre> Tom,
> Pierre> would you have some time to
> Pierre> take again a look at this?
>
> This looks pretty good. A couple nits and it is ok.
>
> >> + /* Multi-byte character types. */
>
> I think it is more clear to describe these as "wide" character types.
> I have usually seen "multi-byte" used synonymously with "variable
> length".
>
> This comment appears twice.
>
> >> + The case of strings is handled n decode_format, only explicit
>
> Typo, s/n/in/
>
> Ok with those changes. Thanks.
Thanks for the review,
patch committed.
Pierre