This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] sim: profile: implement --profile-file backend


On Wed, Apr 21, 2010 at 1:48 PM, Mike Frysinger <vapier@gentoo.org> wrote:
> The profile code already has options and handling for accepting a file to
> write the profile output like the trace code, but it doesn't actually use
> it. ?At the moment, it simply opens the file at the start and closes it at
> the end. ?So add two new local functions the way the trace code is doing
> it and have them figure out whether to write the output to stdout or the
> specified file. ?Then convert all existing output in the profile code to
> use these helpers.
>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
> 2010-04-21 ?Mike Frysinger ?<vapier@gentoo.org>
>
> ? ? ? ?* sim-profile.c (profile_vprintf, profile_printf): New functions.
> ? ? ? ?(profile_print_pc): Convert sim_io_printf to profile_printf.
> ? ? ? ?(profile_print_insn): Likewise.
> ? ? ? ?(profile_print_memory): Likewise.
> ? ? ? ?(profile_print_core): Likewise.
> ? ? ? ?(profile_print_model): Likewise.
> ? ? ? ?(sim_profile_print_bar): Likewise.
> ? ? ? ?(profile_print_speed): Likewise.
> ? ? ? ?(profile_print_addr_ranges): Likewise.
> ? ? ? ?(profile_info): Likewise.
> ? ? ? ?* sim-profile.h (sim_profile_print_bar): Add cpu argument.
>

This patch is ok.
Thanks!


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]