This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: PATCH: Fix 32bit coredump read on Linux/AVX
> Date: Wed, 21 Apr 2010 13:18:20 -0700
> From: "H.J. Lu" <hongjiu.lu@intel.com>
>
> On Tue, Apr 20, 2010 at 11:43:39AM -0700, H.J. Lu wrote:
> > On Mon, Apr 19, 2010 at 08:22:34PM -0700, H.J. Lu wrote:
> > > Hi,
> > >
> > > This patch:
> > >
> > > http://sourceware.org/ml/gdb-patches/2010-04/msg00276.html
> > >
> > > breaks 32bit coredump read on Linux/AVX since we only dump .reg and
> > > .reg-xstate sections on AVX. But i386_linux_core_read_description
> > > checks .reg2 and .reg-xfp sections first. Since there are no
> > > .reg2 and .reg-xfp sections, NULL is returned and SSE target is used.
> > > This patch changes the section check order to .reg-xstate, .reg-xfp,
> > > .reg2. OK to install?
> > >
> > > Thanks.
> > >
> >
> > .reg2 section has x87 regiters on i386 and SSE registers on amd64.
> > Here is the updated patch to properly handle it. OK to install?
> >
> > Thanks.
> >
> >
> > H.J.
> > --
> > 2010-04-20 H.J. Lu <hongjiu.lu@intel.com>
> >
> > PR corefiles/11523
> > * amd64-linux-tdep.c (amd64_linux_core_read_description): Check
> > XCR0 first.
> >
> > * i386-linux-tdep.c (i386_linux_core_read_xcr0): Return 0 if
> > there is no .reg-xstate section.
> > (i386_linux_core_read_description): Check XCR0 first.
> >
>
> This is the version I am checking in.
Looks good, thanks!
> 2010-04-21 H.J. Lu <hongjiu.lu@intel.com>
>
> PR corefiles/11523
> * amd64-linux-tdep.c (amd64_linux_core_read_description): Check
> XCR0 first.
>
> * i386-linux-tdep.c (i386_linux_core_read_xcr0): Return 0 if
> there is no .reg-xstate section.
> (i386_linux_core_read_description): Check XCR0 first.