This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] disassemble support start,+length format
- From: Tom Tromey <tromey at redhat dot com>
- To: crquan at gmail dot com
- Cc: gdb-patches at sourceware dot org, Eli Zaretskii <eliz at gnu dot org>, Nathan Froyd <froydnj at codesourcery dot com>, Hui Zhu <teawater at gmail dot com>, Joel Brobecker <brobecker at adacore dot com>
- Date: Tue, 20 Apr 2010 09:42:50 -0600
- Subject: Re: [PATCH] disassemble support start,+length format
- References: <1270739689-28732-1-git-send-email-crquan@gmail.com> <1271382149-15177-1-git-send-email-crquan@gmail.com>
- Reply-to: tromey at redhat dot com
>>>>> ">" == Cheng Renquan <crquan@gmail.com> writes:
>> +2010-04-15 CHENG Renquan <rqcheng@smu.edu.sg>
>> +
>> + * gdb/cli/cli-cmds.c (disassemble_command): Add support of disassemble
>> + "start,+length" form of arguments.
>> + * gdb/doc/gdb.texinfo: Update disassemble description of two forms of
>> + arguments, and add new example to demonstrate the new form.
A couple notes on the ChangeLog entry.
First, file names should be relative to the directory holding the
ChangeLog file. So, the leading "gdb/" should be removed.
Second, doc/ has its own ChangeLog, so you don't need an entry for it in
gdb/ChangeLog.
Third, the NEWS change should be mentioned.
This patch is ok with those updates, once your paperwork is all done.
Be sure to let us know when that happens.
Tom