This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH] sim: constify sim_write source buffer
- From: Mike Frysinger <vapier at gentoo dot org>
- To: gdb-patches at sourceware dot org
- Date: Sat, 10 Apr 2010 17:58:07 -0400
- Subject: [PATCH] sim: constify sim_write source buffer
Most the sim write functions declare their source buffer const because
they only ever read from it. The global sim_write() function does not
follow this convention though which causes some warnings when trying to
pass it const strings or buffers.
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
include/gdb/:
2010-04-10 Mike Frysinger <vapier@gentoo.org>
* remote-sim.h (sim_write): Add const to buf arg.
sim/common/:
2010-04-10 Mike Frysinger <vapier@gentoo.org>
* sim-hrw.c (sim_write): Add const to buf arg.
* sim-utils.h (sim_write_fn): Likewise.
include/gdb/remote-sim.h | 2 +-
sim/common/sim-hrw.c | 2 +-
sim/common/sim-utils.h | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/gdb/remote-sim.h b/include/gdb/remote-sim.h
index cfb1c11..37f029a 100644
--- a/include/gdb/remote-sim.h
+++ b/include/gdb/remote-sim.h
@@ -175,7 +175,7 @@ int sim_read PARAMS ((SIM_DESC sd, SIM_ADDR mem, unsigned char *buf, int length)
memory. Store bytes starting at virtual address MEM. Result is
number of bytes write, or zero if error. */
-int sim_write PARAMS ((SIM_DESC sd, SIM_ADDR mem, unsigned char *buf, int length));
+int sim_write PARAMS ((SIM_DESC sd, SIM_ADDR mem, const unsigned char *buf, int length));
/* Fetch register REGNO storing its raw (target endian) value in the
diff --git a/sim/common/sim-hrw.c b/sim/common/sim-hrw.c
index e76a196..cedae87 100644
--- a/sim/common/sim-hrw.c
+++ b/sim/common/sim-hrw.c
@@ -32,7 +32,7 @@ sim_read (SIM_DESC sd, SIM_ADDR mem, unsigned char *buf, int length)
}
int
-sim_write (SIM_DESC sd, SIM_ADDR mem, unsigned char *buf, int length)
+sim_write (SIM_DESC sd, SIM_ADDR mem, const unsigned char *buf, int length)
{
SIM_ASSERT (STATE_MAGIC (sd) == SIM_MAGIC_NUMBER);
return sim_core_write_buffer (sd, NULL, write_map,
diff --git a/sim/common/sim-utils.h b/sim/common/sim-utils.h
index 75d2fb4..e3ff63a 100644
--- a/sim/common/sim-utils.h
+++ b/sim/common/sim-utils.h
@@ -63,7 +63,7 @@ SIM_RC sim_analyze_program (SIM_DESC sd, char *prog_name,
This is still accommodated for backward compatibility reasons. */
typedef int sim_write_fn PARAMS ((SIM_DESC sd, SIM_ADDR mem,
- unsigned char *buf, int length));
+ const unsigned char *buf, int length));
struct bfd *sim_load_file (SIM_DESC sd, const char *myname,
host_callback *callback, char *prog,
struct bfd *prog_bfd, int verbose_p,
--
1.7.0.2