Re: [PATCH] disassemble support start,+length format

[Cheng Renquan <crquan at gmail dot com>]

On Sun, Apr 11, 2010 at 5:01 AM, Cheng <crquan@gmail.com> wrote:
> Index: gdb/cli/cli-cmds.c
[...]
> @@ -1119,8 +1120,16 @@ disassemble_command (char *arg, int from
> Â else
> Â Â {
> Â Â Â /* Two arguments. Â*/
> + Â Â Âint incl_flag = 0;
> Â Â Â low = pc;
> + Â Â Âif (arg[0] == '+')
> + Â Â Â{
> + Â Â Â ++arg;
> + Â Â Â incl_flag = 1;
> + Â Â Â}
> Â Â Â high = parse_and_eval_address (arg);
> + Â Â Âif (incl_flag)
> + Â Â Â high += low;
This should satisfy GNU Coding Standards well,

On Fri, Apr 9, 2010 at 6:27 PM, Eli Zaretskii <eliz@gnu.org> wrote:
>> OK, I really know little about texinfo writing; Thanks,
>
> That's fine, I'm here to help ;-)
>
> Thanks for working on this.

I think there to add one disassemble example in the info file may be
better, but haven't figured out how to preview such a texinfo file,
the make process seems not touch it or use it to generate another
file?

suseuser@linux-orm5:~/src/gdb-trunk/src> info -f gdb/doc/gdb.texinfo
info: Cannot find node `Top'.

On Sat, Apr 10, 2010 at 2:14 AM, Tom Tromey <tromey@redhat.com> wrote:
>>> From: CHENG Renquan <rqcheng@smu.edu.sg>
>>> add new support for disassemble by "start,+length" format;
>
> Do you have a copyright assignment in place?
> If not, let me know and I can get you started.

Not yet, you may mean a signed agreement to GNU FSF? I was formerly
asked to sign one when posting a patch to GNU wget last year, but
still don't get further messages there, I wonder if softcopy of
signment is accepted? please help get me restarted since this gdb
patch, thanks,

-- 
Cheng Renquan (çäå), from Singapore