This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] disassemble support start,+length format
- From: Eli Zaretskii <eliz at gnu dot org>
- To: crquan at gmail dot com
- Cc: gdb-patches at sourceware dot org, teawater at gmail dot com, brobecker at adacore dot com
- Date: Fri, 09 Apr 2010 11:21:55 +0300
- Subject: Re: [PATCH] disassemble support start,+length format
- References: <1270786615-29934-1-git-send-email-crquan@gmail.com>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> From: crquan@gmail.com
> Cc: Joel Brobecker <brobecker@adacore.com>,
> Eli Zaretskii <eliz@gnu.org>
> Date: Fri, 9 Apr 2010 12:16:55 +0800
>
> +* Changed commands
> +
> +disassemble
> + The disassemble command, add "start,+length" form of two arguments support.
> +
> *** Changes in GDB 7.1
>
> * C++ Improvements
> @@ -334,8 +339,9 @@ or the "condition" command is available.
> the target for evaluation using the same bytecode format as is used
> for tracepoint actions.
>
> -* "disassemble" command with a /r modifier, print the raw instructions
> -in hex as well as in symbolic form.
> +* The "disassemble" command with an optional /r modifier, print the raw
> +instructions in hex as well as in symbolic form; optional /m modifier to
> +print mixed source+assembly.
Thanks. But please use the style we use in other NEWS entries.
Something like "The disassemble command now supports ..." etc.
> +arguments specify a range of addresses, in the form of "start,end" or
> +"start,+length", stand for [start,end) and [start,start+length), (first
> +inclusive, second exclusive) to dump. In that case, the name of the
> +function is also printed (since there could be several functions in the
> +given range).
I suggest to rephrase as follows:
arguments specify a range of addresses to dump, in one of two forms:
@table @code
@item @var{start},@var{end}
the addresses from @var{start} (inclusive) to @var{end} (exclusive)
@item @var{start},+@var{length}
the addresses from @var{start} (inclusive) to
@code{@var{start}+@var{length}} (exclusive).
@end table
@noindent
When 2 arguments are specified, the name of the function is also
printed (since there could be several functions in the given range).
Note that I used @var{start},@var{end}}, instead of using double
quotes (which is generally a no-no in Texinfo sources).