This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC] Fix for Go32-v2 native woes
- From: Mark Kettenis <mark dot kettenis at xs4all dot nl>
- To: eliz at gnu dot org
- Cc: pierre dot muller at ics-cnrs dot unistra dot fr, gdb-patches at sourceware dot org
- Date: Tue, 6 Apr 2010 20:41:01 +0200 (CEST)
- Subject: Re: [RFC] Fix for Go32-v2 native woes
- References: <002a01cad517$d36eab90$7a4c02b0$%muller@ics-cnrs.unistra.fr> <001801cad593$8e70daf0$ab5290d0$%muller@ics-cnrs.unistra.fr> <83iq84xyoa.fsf@gnu.org>
> Date: Tue, 06 Apr 2010 20:45:25 +0300
> From: Eli Zaretskii <eliz@gnu.org>
>
> > From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
> > Date: Tue, 6 Apr 2010 16:15:05 +0200
> >
> > I finally managed to find a fix, but it is not straightforward:
> > I had to add a new xml file in features/i386 directory
> > specific for go32v2 target, that does not read i386-sse.xml.
> > I had to adapt the code in i386-tdep.c to support
> > missing feature_vector and to set tdesc to
> > tdesc_i386_go32v2 instead of tdesc_i386 when go32v2
> > osabi was detected.
> >
> > This allows me to use CVS GDB on DJGPP again.
> >
> > I checked with a testsuite run on gcc-farm that nothing changed
> > for at least that other target (amd64-linux).
> >
> > Similar fixes might be required for other 'old'
> > i386 targets that do not support SSE registers.
> >
> > Comments welcome as usual!
>
> Thanks. But I really hope that a much more elegant solution could be
> found. A general layer of code such as i386-tdep.c should not include
> any code that is specific to certain targets.
>
> Why do we always read i386-sse.xml or assume that SSE is supported?
> We should not assume any CPU features by default if there are CPUs out
> there which we support that don't have them.
Because that basically was the situation before. When SSE support was
addid we didn't really have a way to detect whether a target supported
SSE or not.
Does Go32 really have no support for the SSE registers?