Re: [PATCH] gdb: tests/monitor: set remotetimeout to gdb_load_timeout for remote targets

[Mike Frysinger <vapier at gentoo dot org>]

On Sunday 14 March 2010 21:52:11 Jie Zhang wrote:
> On 03/15/2010 06:02 AM, Mike Frysinger wrote:
> > From: Jie Zhang<jie@codesourcery.com>
> > 
> > Rather than relying on the default remotetimeout value (which might be
> > too small for some slower devices), use the existing gdb_load_timeout
> > config option to set it.
> > 
> > Signed-off-by: Jie Zhang<jie@codesourcery.com>
> > Signed-off-by: Mike Frysinger<vapier@gentoo.org>
> > ---
> > 2010-03-14  Jie Zhang<jie@codesourcery.com>
> > 
> > 	* gdb/testsuite/config/monitor.exp (gdb_load): New decimal variable.
> > 	Save remotetimeout setting in oldremotetimeout.  Set remotetimeout to
> > 	$loadtimeout.  Restore when done.
> 
> I think this patch is not needed for Blackfin now. I believe any
> testcase in GDB can be loaded via gnICE in seconds now.

yes, your work on the gnICE/gnICE+ means the slow loading is a thing of the 
past, but i think your changes here are reasonable and address a real problem
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.