This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[RFA] fix thinko in arm-tdep.c arm_stub_unwind_sniffer
- From: dje at google dot com (Doug Evans)
- To: gdb-patches at sourceware dot org
- Date: Wed, 3 Mar 2010 18:05:23 -0800 (PST)
- Subject: [RFA] fix thinko in arm-tdep.c arm_stub_unwind_sniffer
Hi.
Ok to check in?
[The result is a boolean indicating success, so why call
target_read_memory if in_plt_section failed, and why return non-zero
if target_read_memory failed?]
2010-03-03 Doug Evans <dje@google.com>
* arm-tdep.c (arm_stub_unwind_sniffer): Fix thinko.
Index: arm-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/arm-tdep.c,v
retrieving revision 1.297
diff -u -p -r1.297 arm-tdep.c
--- arm-tdep.c 26 Feb 2010 20:46:00 -0000 1.297
+++ arm-tdep.c 4 Mar 2010 02:01:21 -0000
@@ -1213,7 +1213,7 @@ arm_stub_unwind_sniffer (const struct fr
addr_in_block = get_frame_address_in_block (this_frame);
if (in_plt_section (addr_in_block, NULL)
- || target_read_memory (get_frame_pc (this_frame), dummy, 4) != 0)
+ && target_read_memory (get_frame_pc (this_frame), dummy, 4) == 0)
return 1;
return 0;