This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] linux-dp tweaks for android


> Android doesn't have rand_r, so I'm proposing replacing it with rand.
> I _think_ this part of the change is ok, but I wouldn't mind
> another pair of eyes ...

I think this part is fine too - your call to rand/rand_r is protected
by a mutex, so all calls should be sequential.

> 2010-03-02  Doug Evans  <dje@google.com>
> 
> 	testsuite/
> 	* gdb.threads/linux-dp.c (shared_random): Call rand instead of rand_r.
> 	* gdb.threads/linux-dp.exp: Compile with gdb_compile_pthreads instead
> 	of gdb_compile.  Add another pattern to match android backtrace.

Looks good to me.

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]