Re: Multiexec MI

[Eli Zaretskii <eliz at gnu dot org>]

> From: Vladimir Prus <vladimir@codesourcery.com>
> Date: Sat, 20 Feb 2010 13:54:55 +0300
> Cc: gdb-patches@sourceware.org
> 
> >   The @var{thread-group} field, if present, specifies the id of the
> >   thread group in whose context the library was loaded. 
> > 
> > Does this express what you meant?
> 
> Oh, it does. Thanks.
>  
> > > > > +Identifier of the thread group.  This field is always present.  The
> > > > > +identifier is an opaque string, and is not necessary an integer.
> > > >                                               ^^^^^^^^^
> > > > "necessarily"
> > > > 
> > > > Also, "is an opaque string, and is not necessarily an integer" sounds
> > > > strange: if it's a string, how can it be an integer?  Do you mean to
> > > > say that the string includes non-digit characters?
> > > 
> > > How about: "The identifier is an opaque string; frontends should not
> > > try to convert it to integer".
> > 
> > I suggest a slight variation:
> > 
> >   The identifier is an opaque string; frontends should not try to
> >   convert it to an integer, even though it might look like one.
> 
> I've used your wording. Revised patch attached.

It's okay, but please fix this small typo when you commit:

> --- a/gdb/doc/observer.texi
> +++ b/gdb/doc/observer.texi
> @@ -199,13 +199,23 @@ The thread's ptid has changed.  The @var{old_ptid} parameter specifies
>  the old value, and @var{new_ptid} specifies the new value.
>  @end deftypefun
>  
> -@deftypefun void inferior_appeared (int @var{pid})
> -@value{GDBN} has attached to a new inferior identified by @var{pid}.
> +@deftypefun void inferior_added (struct inferior *@var{inf})
> +The inferior @var{inf} has been added to the list of inferior.  At
                                                        ^^^^^^^^
This should be "inferiors".

Thanks.