This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Function-like cast notation support
- From: Tom Tromey <tromey at redhat dot com>
- To: SÃrgio Durigan JÃnior <sergiodj at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 17 Feb 2010 11:47:29 -0700
- Subject: Re: [PATCH] Function-like cast notation support
- References: <201002171345.36988.sergiodj@redhat.com>
- Reply-to: tromey at redhat dot com
>>>>> "SÃrgio" == SÃrgio Durigan JÃnior <sergiodj@redhat.com> writes:
SÃrgio> The following patch adds support for function-like cast notation
SÃrgio> on GDB.
This looks good.
It could use a NEWS entry. I suggest waiting until my NEWS change goes
in, then adding it to the C++ improvements section.
SÃrgio> Currently it only works for primitive data type (int,
SÃrgio> char, double, etc), but I intend to send another patch soon that
SÃrgio> will implement this feature for classes as well.
Hmm, you seem to have implemented this already...
SÃrgio> +typebase_single
SÃrgio> : TYPENAME
SÃrgio> { $$ = $1.type; }
... because the lexer can return TYPENAME for a class name.
SÃrgio> + { "void" "void" "'a'" "void" }
I didn't realize this was supposed to work... learn something every day
:-)
This patch is ok. Thanks.
For future reference, it is worth noting in the email how and whether
you regression tested it. I assume that everybody does this, but it is
nice to be explicit about it. At least in my case, this occasionally
helps me realize that I forgot.
Tom