This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Always use addr info to add a separate debug file
- From: Tom Tromey <tromey at redhat dot com>
- To: Tristan Gingold <gingold at ACT-Europe dot FR>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 06 Jan 2010 12:42:39 -0700
- Subject: Re: [RFA] Always use addr info to add a separate debug file
- References: <20100106111823.GA15402@chinon.act-europe.fr>
- Reply-to: tromey at redhat dot com
>>>>> "Tristan" == Tristan Gingold <gingold@ACT-Europe.FR> writes:
Tristan> 2010-01-04 Tristan Gingold <gingold@adacore.com>
Tristan> * symfile.c (build_section_addr_info_from_objfile): New function.
Tristan> (symbol_file_add_separate): Don't use offsets from objfile but
Tristan> built an addr info.
Thanks. Just one nit.
Tristan> + sap->other[i].addr = bfd_get_section_vma (objfile->obfd, sec)
Tristan> + + objfile->section_offsets->offsets[i];
According to GNU rules the RHS of the assignment should be
parenthesized, and the second line thus more deeply indented.
Ok with that change.
Tom