This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Fix verification of changed values for big values.


On Wed 30 Dec 2009 17:21:23 Joel Brobecker wrote:
> > The purpose of the function is rather simple, so I didn't have much to
> > say. I added this description:
> >
> > /* Evaluate watchpoint condition expression and check if its value
> > changed.  */
> 
> Thanks. I thought it was important to explain what the real type of
> parameter P was so I added an extra sentence to the documentation.
> Patch attached.

Sorry about that. You mentioned that concern but it slipped my mind somehow.

> > You're right. IIRC I used gdb_expect because I wanted to explicitly check
> > for the gdb prompt in my regex, to avoid it being too greedy.
> 
> Just for the fun of discussion (I am French, after all :-), I am
> pretty sure that you can also do that with gdb_test_multiple...

Nice. Thanks for the tip! It's even in the DeveloperTips page of the wiki. I 
should have known. :-)
-- 
[]'s
Thiago Jung Bauermann
IBM Linux Technology Center


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]