This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On Wed, Dec 09, 2009 at 08:32:34AM -0500, Chris Moller wrote:
The patch file includes the patch to gdb/valops.c, gdb/ChangeLog, gdb/testsuite/ChangeLog, gdb/testsuite/gdb.cp/Makefile.in, and mc-log.diffs. (The patch to Makefile.in is to incorporate the testcase for 'make check'; mc-log.diffs are the diffs between before and after runs of 'make check')
Next time, please diff -u gdb.sum files; the rest is just noise.
Those do vary a little bit but they're more stable. It looks like your only change is mi-nsmoribund.exp, which is sometimes flaky.
I can't do a 'cvs add' so the the testcase expects and .cc file are attached separately as gdb/testsuite/gdb.cp/virtfunc2.cc and gdb/testsuite/gdb.cp/virtfunc2.exp.
Take a look at cvsutils; "cvsdo add" works.
(Or, nowadays, I suppose you could use the git mirror! :-)
You can see what the patch does by compiling -g virtfunc.cc, gdb-ing it, breaking in the return stmt at // marker1, and doing things like "print o.do_print()". Without the patch, gdb tries to access location 0x0; with the patch it does the right thing. (There are more tests in virtfunc2.exp)
Where does the access to 0x0 come from? Is it inside search_struct_field?
I wouldn't expect value_cast_structs to do any cast in this case,
but it does do a little extra work.
+ if ((TYPE_NAME (t1) != NULL)&& + (TYPE_NAME (t2) != NULL)&& + !strcmp (TYPE_NAME (t1), TYPE_NAME (t2)))
&& on the beginning of the line, please.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |