This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [python][patch] And range method to type
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Phil Muldoon <pmuldoon at redhat dot com>
- Cc: gdb-patches ml <gdb-patches at sourceware dot org>
- Date: Fri, 4 Dec 2009 09:19:06 -0800
- Subject: Re: [python][patch] And range method to type
- References: <4B1929DC.7070809@redhat.com>
This is not an official review, as I don't have much experience
exporting to Python, but it seems right to me. Just one minor
cosmetic comment:
> + if (TYPE_CODE (type) != TYPE_CODE_ARRAY &&
> + TYPE_CODE (type) != TYPE_CODE_STRING &&
> + TYPE_CODE (type) != TYPE_CODE_RANGE)
The && operators should be at the beginning of the line (GNU Coding
Standards):
if (TYPE_CODE (type) != TYPE_CODE_ARRAY
&& TYPE_CODE (type) != TYPE_CODE_STRING
&& TYPE_CODE (type) != TYPE_CODE_RANGE)
--
Joel