This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [python][patch] Add is_base_class attribute to fields.
- From: Tom Tromey <tromey at redhat dot com>
- To: Phil Muldoon <pmuldoon at redhat dot com>
- Cc: gdb-patches ml <gdb-patches at sourceware dot org>
- Date: Tue, 01 Dec 2009 13:51:32 -0700
- Subject: Re: [python][patch] Add is_base_class attribute to fields.
- References: <4B13A147.2040208@redhat.com>
- Reply-to: tromey at redhat dot com
>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:
Phil> Later I fixed a bug/added tests to capture a regression this
Phil> functionality caused.
Phil> http://sourceware.org/ml/archer/2009-q4/msg00016.html?
The tests are nice but they don't actually check the is_base_class field.
Could you add a test to do that?
Other than that I think the code bits are ok. It needs a doc review.
Phil> +# Run a command in GDB, and report a failure if a Python exception is
Phil> thrown.
Your mailer seems to have wrapped the patch.
Tom