This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [python][patch] Add is_base_class attribute to fields.


>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:

Phil> Later I fixed a bug/added tests to capture a regression this
Phil> functionality caused.
Phil> http://sourceware.org/ml/archer/2009-q4/msg00016.html?

The tests are nice but they don't actually check the is_base_class field.
Could you add a test to do that?

Other than that I think the code bits are ok.  It needs a doc review.

Phil> +# Run a command in GDB, and report a failure if a Python exception is
Phil> thrown.

Your mailer seems to have wrapped the patch.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]