This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Allow "disassemble 'Foo::bar(char *)'"


On Sat, Nov 21, 2009 at 12:35 AM, Eli Zaretskii <eliz@gnu.org> wrote:

> You say everywhere in the docs that
> the 2 arguments should be "separated by comma". ?("Separated by a
> comma" would be more correct, English-wise.)

Fixed.

>?However, the test files
> show that the arguments can in fact be separated by a combination of a
> comma and whitespace:
>
>> -test_dis "disassem &staticvar &staticvar+1" "staticvar"
>> +test_dis "disassem &staticvar, &staticvar+1" "staticvar"
>
> Is my interpretation of the test correct? ?If it is, then the
> documentation should say that whitespace is allowed around the comma.

The comma separates expressions, and expressions may contain
{leading,trailing,in the middle} whitespace.

I've added a statement to gdb.texinfo to clarify that.

I also see that I didn't update the two-argument example there; now fixed.

Thanks,
-- 
Paul Pluzhnikov

gdb/ChangeLog:

2009-11-21  Paul Pluzhnikov  <ppluzhnikov@google.com>

      * cli/cli-cmds.c (disassemble_command): Split on comma.
      (init_cli_cmds): Update help.
      * NEWS: Mention incompatible change to 'disassemble'.

gdb/doc/ChangeLog:

2009-11-21  Paul Pluzhnikov  <ppluzhnikov@google.com>

      * gdb.texinfo (Machine Code): Adjust.

gdb/testsuite/ChangeLog:

2009-11-21  Paul Pluzhnikov  <ppluzhnikov@google.com>

      * gdb.asm/asm-source.exp: Adjust.
      * gdb.base/help.exp: Adjust.

Attachment: gdb-disas-20091121.txt
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]