This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[patch]: Handle addresses via CORE_ADDR in readcoff.c


Hello,

I notice that in readcoff.c there are some nits, which cause for x64
windows some troubles.

Changelog for gdb

2009-10-13  Kai Tietz  <kai.tietz@onevision.com>

	* coffread.c (coff_symbol): Use for c_value CORE_ADDR to synchronize it
	with coff internal definition. Adjusted comment to not exceed 80 character
	line size.
	(coff_symtab_read): Define fcn_start_addr as CORE_ADDR.

Tested for x86_64-pc-mingw32 and for i686-pc-mingw32. Ok for apply to trunk?

Cheers,
Kai

-- 
|  (\_/) This is Bunny. Copy and paste
| (='.'=) Bunny into your signature to help
| (")_(") him gain world domination

Index: coffread.c
===================================================================
RCS file: /cvs/src/src/gdb/coffread.c,v
retrieving revision 1.96
diff -u -r1.96 coffread.c
--- coffread.c  6 Oct 2009 22:47:20 -0000       1.96
+++ coffread.c  13 Oct 2009 13:48:36 -0000
@@ -127,9 +127,11 @@
 struct coff_symbol
   {
     char *c_name;
-    int c_symnum;              /* symbol number of this entry */
-    int c_naux;                        /* 0 if syment only, 1 if
syment + auxent, etc */
-    long c_value;
+    /* symbol number of this entry */
+    int c_symnum;
+    /* 0 if syment only, 1 if syment + auxent, etc */
+    int c_naux;
+    CORE_ADDR c_value;
     int c_sclass;
     int c_secnum;
     unsigned int c_type;
@@ -703,7 +705,7 @@
   int fcn_first_line = 0;
   CORE_ADDR fcn_first_line_addr = 0;
   int fcn_last_line = 0;
-  int fcn_start_addr = 0;
+  CORE_ADDR fcn_start_addr = 0;
   long fcn_line_ptr = 0;
   int val;
   CORE_ADDR tmpaddr;


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]