This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Remove dead aix and irix related bits from gdb_compile.
- From: Pedro Alves <pedro at codesourcery dot com>
- To: gdb-patches at sourceware dot org
- Date: Sun, 4 Oct 2009 15:37:18 +0100
- Subject: Remove dead aix and irix related bits from gdb_compile.
Bringing to closure a conclusion from the
"Avoid auto-import warning on cygwin/mingw" thread, this removes a
bit of dead code from gdb_compile. The code is appending to `options',
but `options' is reset just a bit below, after the foreach ends.
While looking at cvs history and the archives, checking if the code
was made dead by mistake, I found the patch that seems to have added
the code in question, which makes me believe that these bits
has always been dead:
http://sources.redhat.com/ml/gdb-patches/2004-11/msg00538.html
Anyway, almost 5 years without anyone missing this, I say we
simply drop the code as is for now.
I paranoid-regtested this on x86_64-linux. I don't have access to
aix or irix though.
--
Pedro Alves
2009-10-04 Pedro Alves <pedro@codesourcery.com>
* lib/gdb.exp (gdb_compile): Remove dead aix and irix related
bits.
---
gdb/testsuite/lib/gdb.exp | 14 ++++----------
1 file changed, 4 insertions(+), 10 deletions(-)
Index: src/gdb/testsuite/lib/gdb.exp
===================================================================
--- src.orig/gdb/testsuite/lib/gdb.exp 2009-10-04 14:56:12.000000000 +0100
+++ src/gdb/testsuite/lib/gdb.exp 2009-10-04 14:56:18.000000000 +0100
@@ -1723,18 +1723,12 @@ proc gdb_compile {source dest type optio
} else {
lappend source $shlib_name
}
- if {$shlib_found == 0} {
+ if { $shlib_found == 0 } {
set shlib_found 1
- if { ([test_compiler_info "gcc-*"]
- && ([istarget "powerpc*-*-aix*"]
- || [istarget "rs6000*-*-aix*"] )) } {
- lappend options "additional_flags=-L${outdir}"
- } elseif { [istarget "mips-sgi-irix*"] } {
- lappend options "additional_flags=-rpath ${outdir}"
- } elseif { ([istarget "*-*-mingw*"]
- || [istarget *-*-cygwin*]) } {
+ if { ([istarget "*-*-mingw*"]
+ || [istarget *-*-cygwin*]) } {
lappend new_options "additional_flags=-Wl,--enable-auto-import"
- }
+ }
}
} elseif { $opt == "shlib_load" } {
if { ([istarget "*-*-mingw*"]