This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA/commit] ia64: incorrect breakpoint save/restore with L-type instruction at slot 1


On Tue, 29 Sep 2009 21:14:01 +0200, Joel Brobecker wrote:
> > gdb/testsuite/
> > 2009-09-29  Jan Kratochvil  <jan.kratochvil@redhat.com>
> > 
> > 	* gdb.base/breakpoint-shadow.exp: Move the ia64 part into ...
> > 	* gdb.arch/ia64-breakpoint-shadow.exp, ... a new file, with new tests.
> > 	* gdb.arch/ia64-breakpoint-shadow.S: New file.
> 
> Just one nit, I think. Shouldn't we disassemble bundle, rather than
> main?

I do not find any difference, whole `main' is supplied by the testcase, I do
not see any pros/cons of either of two.  Thanks for the review.


> Pre-approved, HEAD and branch.

Checked-in in the posted form:
	http://sourceware.org/ml/gdb-cvs/2009-09/msg00228.html
	http://sourceware.org/ml/gdb-cvs/2009-09/msg00229.html (gdb_7_0-branch)


Thanks,
Jan


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]