This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 3/N] some minor fixes in sim, gold, gdb
- From: Ralf Wildenhues <Ralf dot Wildenhues at gmx dot de>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Wed, 19 Aug 2009 21:14:56 +0200
- Subject: Re: [PATCH 3/N] some minor fixes in sim, gold, gdb
- References: <20090815112928.GB5396@gmx.de> <20090815113302.GC20172@gmx.de> <20090818184349.GE30742@gmx.de> <m34os3abxy.fsf@fleche.redhat.com>
* Tom Tromey wrote on Wed, Aug 19, 2009 at 08:35:53PM CEST:
> >>>>> "Ralf" == Ralf Wildenhues writes:
>
> Ralf> Of these changes, this one still needs approval:
>
> >> - sim/common/aclocal.m4: SIM_CHECK_MEMBER is alias for AC_CHECK_MEMBER now.
> >> This also needs to happen at the same time as the Autoconf update, to
> >> avoid exposing whatever bugs 2.59's AC_CHECK_MEMBER had.
> >> Is this ok or would you rather I replace every use of SIM_CHECK_MEMBER
> >> with AC_CHECK_MEMBER?
>
> This is ok.
Thanks, got all reviews now.
> I think it would be preferable to just do the replacement.
> However, I realize your patch is pretty huge already.
> So, if you would prefer to just change the definition of
> SIM_CHECK_MEMBER, that is fine by me.
Yes, I think I'd prefer to do this kind of cleanup later.
Cheers,
Ralf