This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 3/N] some minor fixes in sim, gold, gdb


* Tom Tromey wrote on Wed, Aug 19, 2009 at 08:35:53PM CEST:
> >>>>> "Ralf" == Ralf Wildenhues writes:
> 
> Ralf> Of these changes, this one still needs approval:
> 
> >> - sim/common/aclocal.m4: SIM_CHECK_MEMBER is alias for AC_CHECK_MEMBER now.
> >> This also needs to happen at the same time as the Autoconf update, to
> >> avoid exposing whatever bugs 2.59's AC_CHECK_MEMBER had.
> >> Is this ok or would you rather I replace every use of SIM_CHECK_MEMBER
> >> with AC_CHECK_MEMBER?
> 
> This is ok.

Thanks, got all reviews now.

> I think it would be preferable to just do the replacement.
> However, I realize your patch is pretty huge already.
> So, if you would prefer to just change the definition of
> SIM_CHECK_MEMBER, that is fine by me.

Yes, I think I'd prefer to do this kind of cleanup later.

Cheers,
Ralf


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]