This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA] Implement -break-commands

From: Tom Tromey <tromey at redhat dot com>
To: Vladimir Prus <vladimir at codesourcery dot com>
Cc: gdb-patches at sources dot redhat dot com
Date: Thu, 30 Jul 2009 10:02:35 -0600
Subject: Re: [RFA] Implement -break-commands
References: <200907271303.13335.vladimir@codesourcery.com> <m3bpn6jcz9.fsf@fleche.redhat.com> <200907301023.45893.vladimir@codesourcery.com>
Reply-to: Tom Tromey <tromey at redhat dot com>

>>>>> "Volodya" == Vladimir Prus <vladimir@codesourcery.com> writes:

Volodya> This revision addresses all the comments above, except that
Volodya> request for 'closure' pointer to read_command_lines_1 if
Volodya> addressed by a comment saying why we don't do that.

There still isn't a header comment on read_next_line.  Just something
like "helper function for use with recurse_read_control_structure" would
be fine.  This is ok with the addition of a comment.

thanks,
Tom

References:
- [RFA] Implement -break-commands
  - From: Vladimir Prus
- Re: [RFA] Implement -break-commands
  - From: Tom Tromey
- Re: [RFA] Implement -break-commands
  - From: Vladimir Prus

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]