This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[patch] Set bfd field in target_section


Hello,

I believe this is related to Pedro's patch from 03-Jun-09. I didn't see where we set target_section.bfd field - maybe I am overlooking something, but in bfd-target, in function target_bfd_xclose we will call bfd_close (table->sections->bfd); bfd_close doesn't like NULL argument.

Am I missing something, or is this (the patch) missing?

Patch attached.

Thanks,

--
Aleksandar Ristovski
QNX Software Systems

ChangeLog:

* exec.c (build_section_table): Setup section_table bfd field.
Index: gdb/exec.c
===================================================================
RCS file: /cvs/src/src/gdb/exec.c,v
retrieving revision 1.90
diff -u -p -r1.90 exec.c
--- gdb/exec.c	2 Jul 2009 17:21:06 -0000	1.90
+++ gdb/exec.c	28 Jul 2009 14:21:09 -0000
@@ -441,6 +441,7 @@ build_section_table (struct bfd *some_bf
   bfd_map_over_sections (some_bfd, add_to_section_table, (char *) end);
   if (*end > *start + count)
     internal_error (__FILE__, __LINE__, _("failed internal consistency check"));
+  (*start)->bfd = (*end)->bfd = some_bfd;
   /* We could realloc the table, but it probably loses for most files.  */
   return 0;
 }

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]