This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Use data cache for stack accesses
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Jacob Potter <jdpotter at google dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 09 Jul 2009 06:06:16 +0300
- Subject: Re: [RFA] Use data cache for stack accesses
- References: <7e6c8d660907081308r13bff580rdcf4822c77df8403@mail.gmail.com>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> Date: Wed, 8 Jul 2009 13:08:00 -0700
> From: Jacob Potter <jdpotter@google.com>
>
> This is the second half of the pair of patches I first submitted last
> week. Differences from the first pass are:
>
> - Added a NEWS entry for the new option
> - Changed the stackcache option to default to on, rather than off
> - Got rid of the unnecessary new value_at_lazy_stack() function
> - Flush the cache when switching inferiors.
Thanks.
> I haven't changed the new read_stack function to take a target_ops,
> since it's intended to be consistent with read_memory(); converting
> read_memory() to take target_ops would be out of the scope of this
> patch (it and target_read_memory have a *lot* of callers). Other than
> that, I think I've addressed all the issues with the first pass; is
> there anything else to fix?
The NEWS entry is approved. But we need a patch for the manual that
describes the new command and removes the description of remotecache.