This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [rfa/Ada] Restructure fixed array range fall-back to remove builtin types
- From: "Ulrich Weigand" <uweigand at de dot ibm dot com>
- To: brobecker at adacore dot com (Joel Brobecker)
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 29 Jun 2009 19:29:35 +0200 (CEST)
- Subject: Re: [rfa/Ada] Restructure fixed array range fall-back to remove builtin types
Joel Brobecker wrote:
> > * ada-lang.c (to_fixed_range_type): Add ORIG_TYPE argument.
> > Fall back to orig_type as index type if symbol lookup fails.
> > Allocate result types from ORIG_TYPE's objfile.
> > (ada_array_bound_from_type, to_fixed_array_type,
> > ada_evaluate_subexp): Pass original index type to
> > to_fixed_range_type. Do not pass objfile.
> >
> > * ada-typeprint.c (print_range_type_named): Add ORIG_TYPE argument.
> > Fall back to orig_type as index type if symbol lookup fails.
> > (print_array_type, ada_print_type): Pass original index type
> > to print_range_type_named.
>
> This makes sense to me, and I verified that you handle the case of
> array index types that are range types. So OK.
Checked in.
Thanks,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com