This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [rfc] longjmp breakpoints (Re: [00/19] Eliminate some more current_gdbarch uses)
- From: "Ulrich Weigand" <uweigand at de dot ibm dot com>
- To: pedro at codesourcery dot com (Pedro Alves)
- Cc: gdb-patches at sourceware dot org, tromey at redhat dot com
- Date: Wed, 24 Jun 2009 18:43:56 +0200 (CEST)
- Subject: Re: [rfc] longjmp breakpoints (Re: [00/19] Eliminate some more current_gdbarch uses)
Pedro Alves wrote:
> > This patch implements the idea of maintaining "master copies" of the
> > longjmp breakpoints that are created at the same places where overlay
> > event breakpoints are created today, and then installing momentary
> > clones while we want them to be active within a thread.
> >
> > What do you think?
>
> Looks good to me. Thanks!
Thanks for the review!
I've noticed the patch as posted as a silly bug:
> > + ALL_BREAKPOINTS_SAFE (b, temp)
> > + if (b->type == bp_longjmp_master)
> > + {
> > + struct breakpoint *clone = clone_momentary_breakpoint (b);
> > + b->type = bp_longjmp;
> > + b->thread = thread;
> > + }
This obviously needs to set clone->type and clone->thread instead.
I've now re-tested and checked in the fixed version.
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com