This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Move the multi-forks support to the generic multi-inferiors support.


>>>>> "Pedro" == Pedro Alves <pedro@codesourcery.com> writes:

Tom> In this case I think the patch is ok anyway -- an error in "info
Tom> threads" does not, IMO, imply that we should propagate the mistake to
Tom> other commands.  Let me know what you think of this, I won't install
Tom> the patch if you feel differently.

Pedro> No, I agree with you.

Thanks.  I'm am going to commit this shortly.

Pedro> My only concern is that the PID column may end up being
Pedro> the wrong name for the target-id, due to targets that don't have a real
Pedro> notion of PID.  I was planning of making that column's value print
Pedro> something like target_pid_to_str (pid_to_ptid (PID)), just like the
Pedro> corresponding column in info threads.  I was hoping that when
Pedro> we'd get to name the columns in "info threads" we'd come up with
Pedro> a nice name for it.  :-)

I think we can change the column headers, as shown by the CLI (and not
MI?  I am not certain) at some later date, just by changing the
ui_out_table_header calls.  So I'm not too worried.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]