Re: [RFA] Fix bug in add_alias_cmd

[Tom Tromey <tromey at redhat dot com>]

>>>>> "Pierre" == Pierre Muller <muller@ics.u-strasbg.fr> writes:

Pierre>   This is due to "bu" being an alias command of "ubreak"
Pierre> for xdb options, but "ubreak" doesn't seem to exist anywhere
Pierre> and I found no trace of it anywhere is the sources :(

Pierre> I fact after looking at the sources, it appears to me
Pierre> that the assertion itself is wrong.
Pierre> prehookee should also be NULL, as the other pointers tested.

Pierre> This small patch fixes it.

Pierre> OK to commit?

Yes, thanks.
IMO, you could have put this patch in under the "obvious" rule.

Pierre> PS: What should we do about 
Pierre> Could I also remove that line 
Pierre>  if (xdb_commands)
Pierre>     {
Pierre>       add_com_alias ("ba", "break", class_breakpoint, 1);
Pierre>       add_com_alias ("bu", "ubreak", class_breakpoint, 1);
Pierre>     }

You can just delete the "bu" line.

If you want you could do some archaeology to see whether ubreak ever
existed and, if so, when and why it was removed.

Tom