Re: [PATCH 1/4] catch syscall -- try 4 -- Architecture-independent part

[Sérgio Durigan Júnior <sergiodj at linux dot vnet dot ibm dot com>]

Hi Daniel,

On Tue, 2009-03-31 at 11:44 -0400, Daniel Jacobowitz wrote:
> On Sun, Mar 29, 2009 at 03:50:26PM -0300, Sérgio Durigan Júnior wrote:
> > ~"Catchpoint 1 (call to syscall 'chroot'), 0xffffe424 in
> > __kernel_vsyscall ()\n"
> > ~"0xffffe424 <__kernel_vsyscall+16>:\tpop    %ebp\n"
> > *stopped,frame={addr="0xffffe424",func="__kernel_vsyscall",args=[]},thread-id="1",stopped-threads="all"
> 
> > So, what do you think of it? Analyzing it, I think it's not so useful
> > except for the (obvious) part ~"Catchpoint 1 ...".
> 
> Right.  There ought to be a new reason="..." entry; search for
> EXEC_ASYNC_BREAKPOINT_HIT.  There should probably be some semantic
> fields, too, like "old" for watchpoints.

I'm sorry about taking so long to reply your messages, but I'm really
busy with other things here. By the way, that's one of the reasons why
I'm asking this...

Well, I perfectly understand when you (or anyone else here in GDB) ask
me to implement something else in the catch syscall patch, after all
it's important to have a good code in GDB's codebase. But honestly, this
time I think you're exaggerating a little. I know that it would be cool
to have the MI support in the catch syscall feature, and I myself plan
to implement this support in a future not so distant; however, and
specially because I'm very busy these days, I won't be able to dedicate
enough time in order to get it ready for GDB 7.0, and IMHO the catch
syscall would be a *nice* feature to have in this release.

So this is my opinion about this: I have the complete catch syscall
patch here (the only thing that's missing is the MI support), so what do
you think if we just push this patch upstream as-is (which is: in a
pretty good shape, as far as I understood the others developers' --
including yours -- comments), and postpone this MI support? I think I
should be able to sit down and implement this support until the end of
this semester, is it good for you?

Well, thanks for your time, for your valuable reviews about my code, and
for your patience. Please consider my proposal and let me know what you
think about it.

Regards,

-- 
Sérgio Durigan Júnior
Linux on Power Toolchain - Software Engineer
Linux Technology Center - LTC
IBM Brazil