This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Make tracepoints into breakpoints
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Stan Shebs <stan at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Sat, 28 Mar 2009 12:05:29 +0300
- Subject: Re: [PATCH] Make tracepoints into breakpoints
- References: <49CD275B.1020003@codesourcery.com>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> Date: Fri, 27 Mar 2009 12:22:03 -0700
> From: Stan Shebs <stan@codesourcery.com>
>
> Here is the long-threatened patch that makes tracepoints into a type of
> breakpoint.
Some calls to printf_filtered have no translation-friendly _() around
their string arguments:
> + ALL_TRACEPOINTS (t2)
> + if (t1 == (struct breakpoint *) -1 || t1 == t2)
> + {
> + t2->pass_count = count;
> + observer_notify_tracepoint_modified (t2->number);
> + if (from_tty)
> + printf_filtered ("Setting tracepoint %d's passcount to %d\n",
> + t2->number, count);
Here.
> + printf_filtered ("bad tracepoint number at or near '%s'\n",
> + instring);
> + else
> + printf_filtered ("Tracepoint argument missing and no previous tracepoint\n");
> + return NULL;
Same here.
> + /* FIXME: if we are in the middle of a range we don't want to give
> + a message. The current interface to get_number_or_range doesn't
> + allow us to discover this. */
> + printf_unfiltered ("No tracepoint number %d.\n", tpnum);
> + return NULL;
And here.
> + if (from_tty)
> + printf_filtered ("Tracepoints saved to file '%s'.\n", args);
> + return;
And here.