Re: [PATCH] Support new target S+core 3, a variant of S+core

[Joel Brobecker <brobecker at adacore dot com>]

Don,

> 2009-03-20  Don Lee <don.lee@sunplusct.com>:
> 
>         Support new target S+core 3, which is a variant of S+core
> 
>         * gdb/score-tdep.c: support new target S+core 3
>         * gdb/score-tdep.c: Ditto.

These changes were privately approved by Qinwei, so they can be
checked in.

Before you do so, I have a few comments, mostly procedural, so they
should not require too much work.

You will need to have write access priviledges to GDB. If you don't
have these priviledges, can you please visit this web page?
http://www.sourceware.org/cgi-bin/pdw/ps_form.cgi

Once you write access have been granted, please add yourself to the
WRITE AFTER APPROVAL section in the gdb/MAINTAINERS file. Please make
sure to send the associated patch and ChangeLog entry to gdb-patches,
so we can all know that the change was made.

About the score changes, the ChangeLog entry for your changes to GDB
are meant to be added at the start of the gdb/ChangeLog file - filenames
in your entry should be relative to the ChangeLog file, so omit the "gdb/"
in the filenames above.  Also, there is a typo above, as you mentioned
the same filename twice.  And finally, you should be using sentences,
which mean starting with a capital letter, and ending with a period.
Here is an example of an acceptable entry:

        * score-tdep.h, score-tdep.c: Add support for S+core 3.

The change in gdb/configure.ac is also approved, but please repost
the patch with the associated ChangeLog entry as well.

And finally, it would be great if you could post your patches with
a different encoding than "applica/octet-stream", as this makes it
harder to quote the contents of your patches when replying to your
emails. Fixing this might be as simple as using score.diff as opposed
to score.patch (but I see that you use Lotus Notes, so perhaps not
as easy).

-- 
Joel