This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Submit process record and replay fourth time, 7/8
Hi Pedro,
On Sun, Mar 22, 2009 at 23:30, Pedro Alves <pedro@codesourcery.com> wrote:
>
> The way this is written looks like there's a bunch
> of unneeded duplication.
>
> ?+#define I386_LINUX_RECORD_SIZE__old_kernel_stat ? ? ? ?32
>
> ?+ ?/* Initialize the i386_linux_record_tdep. ?*/
> ?+ ?i386_linux_record_tdep.size__old_kernel_stat =
> ?+ ? ?I386_LINUX_RECORD_SIZE__old_kernel_stat;
>
> Are the I386_LINUX_RECORD_SIZE__XXXXX defines used for
> anything else other than initializing the corresponding
> i386_linux_record_tdep.size_XXXXX field? ?If not, why not
> drop the defines and just write
>
> ?i386_linux_record_tdep.size__old_kernel_stat = 32;
Yes, you are right. I will do it.
>
> ?
>
> Personally, I think that stamping everything with "record" in
> its name is a mistake. ?This is about the linux syscall abi,
> could be reused for something else...
>
About this part, we have a discussion in
http://sourceware.org/ml/gdb-patches/2008-11/msg00171.html
We will make it better later.
Thanks,
Hui