Re: [PATCH] Support new target S+core 3, a variant of S+core

[don dot lee at sunplusct dot com]

gdb-patches-owner@sourceware.org 写于 2009-03-17 23:57:43:

> 
> 
> Note that Qinwei is also capable of reviewing your code.
> I can take a look, but it's better if Qinwei does it, because he has
> actual knowledge of the target.

These code have been reviewed by Qinwei. Actually, part of the codes are 
written by him. 


> 
> If you haven't done so, the gdb/CONTRIBUTE file contains valuable
> information. You may also want to give gdb/MAINTAINERS a quick read.
> 
> The first thing that struck me was the fact that the patch was produced
> in the wrong format, so "context" is missing. Could you resubmit your
> patch using the "-u" option? For instance "cvs diff -u ...".

Sorry, forget that, my mistake.

> 
> Also, it looks like you are submitting several changes in one patch,
> which we prefer not to. For instance, your change to gdb/configure.tgt
> can be submitted as is, as it is independent of the target; it just
> tells gdb about the the simulator.

These changes are parts of a logical change, so I think submit as a whole 
is OK.
But this time, I put change about gdb/configure.tgt on another patch.

> In any case,
> this is also an independent change, so this can be submitted separately
> from the rest.

By now, leave them alone for a moment.

> 
> There is no score subdirectory in sim/. Are you going to submit
> a simulator for that target?

We have a simulator for it, so put a check for simulator in 
gdb/configure.tgt 
may make our life a bit easy. But as far as I know, these is no plan to 
submit
this simulator, even in binary form.

> 
> The rest of the patch is very hard to read! Could you explain a little
> bit the actual changes you made? At first sight, what the patch says
> is that you replaced pretty much everything, which I doubt is the case.

The original S+core have been renamed S+core 7, the new variant named 
S+core 3.
So lots of functions in score-tdep.c have been rewritten or been renamed, 
that's
why you see almost everything have changed.

Attachments are my new patches, with context information.

Thank you for your time,
Don

Attachment: gdb-configure.patch
Description: Binary data

Attachment: gdb-score.patch
Description: Binary data