This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC] AR Index: Try to test 'if' assignment errors more correctly
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Pierre Muller <muller at ics dot u-strasbg dot fr>
- Cc: 'Daniel Jacobowitz' <drow at false dot org>, gdb-patches at sourceware dot org
- Date: Fri, 13 Mar 2009 16:11:30 -0700
- Subject: Re: [RFC] AR Index: Try to test 'if' assignment errors more correctly
- References: <000001c9a325$2fbe06f0$8f3a14d0$@u-strasbg.fr>
> This patch tries to do a better job on
> catching assignments inside if statement.
No objection from me. Not sure about the qualify of the code,
since I haven't spent much time using awk. The only thing I noticed
was the fact that you hard-coded the number of lines rather than using
a constant - not sure if that's possible or not.
I suggest that you check it in in a week from now unless someone else
has some comments about this.
--
Joel