This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Wrong inner_frame sanity check with signal frame and -fstack-check
- From: Mark Kettenis <mark dot kettenis at xs4all dot nl>
- To: brobecker at adacore dot com
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 13 Mar 2009 11:44:09 +0100 (CET)
- Subject: Re: [RFA] Wrong inner_frame sanity check with signal frame and -fstack-check
- References: <20090313005019.GJ8386@adacore.com>
> Date: Thu, 12 Mar 2009 17:50:19 -0700
> From: Joel Brobecker <brobecker@adacore.com>
>
> 2009-03-12 Joel Brobecker <brobecker@adacore.com>
>
> * frame.c (get_prev_frame_1): Do not perform the inner_frame
> sanity check if this_frame is not NORMAL.
> (frame_id_inner): Update the description of this function.
>
> This removes a sanity check, so we didn't really expect any change
> in terms of behavior except in the case above, since this is the only
> case we know of where we trip this sanity check. Nonetheless, this
> has been running in our tree since Mid-Dec 2008. And I tested this
> again on amd64-linux. No regression.
>
> Any objection to me checking this patch in?
I think it is reasonable. Most UNIXy systems have sigaltstack(),
which allows one to specify an alternate stack to run signal handlers
on (which Ada uses I presume). I've sometimes wondered how to handle
that properly, but decided not to worry about this until people
actually reported a problem with it.