This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Fix a crash when displaying variables from shared library.


On Fri, Mar 6, 2009 at 9:48 AM, Joel Brobecker <brobecker@adacore.com> wrote:

> (On a side note - I think that "solib_address" is a bad name.
> Independently of this change, we should think about changing it
> to "solib_name_from_address" one of these days).

Attached patch does that.

I didn't touch similarly mis-named xcoff_solib_address, because I can't
see any use of that symbol. Perhaps it should be deleted?

If it's a debug-only helper, I can rename it and add a comment to that
effect.

Thanks,
-- 
Paul Pluzhnikov

2009-03-06  Paul Pluzhnikov  <ppluzhnikov@google.com>

	    Rename solib_address to solib_name_from_address.
	    * breakpoint.c (insert_bp_location, disable_breakpoints_in_shlibs)
	    (disable_breakpoints_in_unloaded_shlib): Update.
	    * printcmd.c (display_uses_solib_p): Likewise.
	    * stack.c (print_frame): Likewise.
	    * solib.c: Rename.
	    * solib.h: Rename.

Attachment: gdb-rename-solib-20090306.txt
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]