Re: [RFA/windows] cast of address to DWORD warning (handle_unload_dll)

[Christopher Faylor <cgf-use-the-mailinglist-please at sourceware dot org>]

On Wed, Jan 14, 2009 at 07:42:02AM +0400, Joel Brobecker wrote:
>Hi Chris,
>
>This is one last case of a conversion of an address to an integer
>type whose size doesn't match on Windows64. I missed this one previously
>because the sources used by AdaCore don't produce this error message[1].
>
>Other than that, I verified that a clean checkout of the sources
>allow us to build GDB on Vista64 with no warning. What's left to do
>is to add the last necessary bits to allow this port to be built
>as a target only, and then announce the port in the NEWS file...
>
>2009-11-14  Joel Brobecker  <brobecker@adacore.com>
>
>        * windows-nat.c (handle_unload_dll): Use host_address to string
>        in order to print the base address of the DLL that was unloaded.
>
>This one is hard to test, because it's supposed to never happen.
>So I tested it by, ahem, visual inspection (I learnt that expression
>at my first job, where we were producing safety critical software).

I guess this is ok.  I just changed other similar occurrences to %p.
Maybe all of those should also be changed for hobgoblinish consistency
or this one should be %p too.

cgf