This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[commit] small cleanup in host address to string conversion


One of the things that caused me the most amount of grief is Microsoft's
decision that "long" should be 4 bytes rather than 8 bytes.  As a result,
one assumption that's made in many areas of our code that sizeof(long)
is the same as sizeof (void*) does not hold, and GCC complains.

Most of the issues caused by this are when we're trying to print
a host address, using long as the format.  There is actually a
routine that transforms a void * into a string, and another one
that prints a void * into a stream.  This patch is just a small
cleanup that makes the latter call the former, to avoid duplicating
the conversion to string.

2009-01-07  Joel Brobecker  <brobecker@adacore.com>

        * utils.c (gdb_print_host_address): Adjust implementation to
        reuse host_address_to_string. Move comment explaining the conversion
        from host address to string from here...
        (host_address_to_string): ... to there.

Tested on x86-linux.  Checked in.

-- 
Joel

Attachment: print_addr.diff
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]