This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFA: Building GDB under GLIBC 2.8


>>>>> "Jim" == Jim Blandy <jimb@red-bean.com> writes:

Jim> The latest version of Ubuntu (Intrepid Ibex) includes a GLIBC that
Jim> attaches the warn_unused_result attribute to many C library functions.
Jim>  The archer project doesn't use the -Wno-unused flag, so I needed to
Jim> fix these to build archer.  It seemed to me that submitting the patch
Jim> upstream would be the most helpful thing to do.

Thanks.

One nit from me:
 
Jim> +static void
Jim> +check_syscall (const char *msg, int result)
Jim> +{

I believe that these days we're asking for intro comments on all new
functions.

I can't approve or reject this, but according to MAINTAINERS, you can :)

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]