Re: [PATCH 0/4] 'catch syscall' feature

[Sérgio Durigan Júnior <sergiodj at linux dot vnet dot ibm dot com>]

Hey Michael :-)

On Wed, 2008-10-01 at 16:51 -0700, Michael Snyder wrote:

> AFAIK, we're still using the CVS repository as the official source
> repo.  I don't use git.  We also ask that patches be relative to
> the current top-of-tree.

Right. I've only used git because I feel more comfortable with it :-).
And my patches are relative to the current top-of-tree, because the git
repository is updated on every 1/2 hour :-).

> However, I've done my best to massage your patch into the current
> cvs tree.  I'm attaching a CVS diff based on my best effort.  Please
> let me know if you can spot any mistakes.

Thank you for this, but I think it won't be needed... Keep reading ;-P

> I was able to build this, but it failed your test case
> (thanks very much for including a test case, by the way).
> I'm attaching my failing gdb.log.

Well, maybe you have misunderstood things (or maybe I wasn't clear
enough :-)). Currently, my patch only works for 32-bit PowerPC
architecture, although I intend to implement the x86 support ASAP.

> I want to thank you for the contribution while strongly
> encouraging you to resubmit it relative to CVS HEAD.

Well, going straight to the "business", I think I know what happened. My
patch is inlined in the message, so it's not just a matter of
"cut-and-paste" it. You must instead take the raw copy of the message
(or messages, in this case), and apply the patches using them. To get
the raw copy of the message, just download these URLs:

http://sourceware.org/cgi-bin/get-raw-msg?listname=gdb-patches&date=2008-09&msgid=1222798409.30389.23.camel%40miki

http://sourceware.org/cgi-bin/get-raw-msg?listname=gdb-patches&date=2008-09&msgid=1222798412.30389.24.camel%40miki

http://sourceware.org/cgi-bin/get-raw-msg?listname=gdb-patches&date=2008-09&msgid=1222798415.30389.26.camel%40miki

http://sourceware.org/cgi-bin/get-raw-msg?listname=gdb-patches&date=2008-09&msgid=1222798416.30389.27.camel%40miki

(Note that if you just open your browser and copy-and-paste the text
won't work either... You must select "Save the page as...", or use a
tool like wget to download the messages).

After that, and if the stars are properly aligned, the patch should
apply correctly :-).

Please, let me know if you have other issues!

Regards,

-- 
Sérgio Durigan Júnior
Linux on Power Toolchain - Software Engineer
Linux Technology Center - LTC
IBM Brazil