This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: How to submit a LARGE patch
- From: Jeremy Bennett <jeremy dot bennett at embecosm dot com>
- To: gdb-patches at sourceware dot org
- Date: Sat, 20 Sep 2008 13:15:49 +0100
- Subject: Re: How to submit a LARGE patch
- References: <1221909745.2827.456.camel@thomas> <ur67foxs8.fsf@gnu.org>
- Reply-to: jeremy dot bennett at embecosm dot com
On Sat, 2008-09-20 at 14:35 +0300, Eli Zaretskii wrote:
> My own preference is to submit is as text, not as binary attachment.
> Unless your mailer does all kinds of dirty tricks with text, such as
> folding long lines etc., this makes reviewing the patch by far the
> easiest.
Thanks for the quick reply.
I'm happy to submit as plain text, but the PNG & PDF versions of the
image have to be binary (or uuencoded binary).
>
> > I've made some suggested changes to the GDB Internals manual, but since
> > the change includes an image, the diff file is nearly 300k, when gzipped
> > and uuencoded.
>
> How large it is before gzip?
500k. That's broken down as:
82k - changes to gdbint.texinfo source
48k - original image (SVG)
1k - text version of image (for info)
67k - PNG version of image (binary, for HTML)
78k - PDF version of image (binary, for PDF)
218k - EPS version of image (for DVI)
gzip reduces it to 200k, uuencoding (as suggested in the CONTRIBUTE
file) inflates it back to 300k.
I can break down the patch into just the Texinfo change and then each
image separately. Your further suggestions on this would be welcome.
Thanks,
Jeremy
--
Tel: +44 (1202) 416955
Cell: +44 (7970) 676050
SkypeID: jeremybennett
Email: jeremy.bennett@embecosm.com
Web: www.embecosm.com