This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH-ppc 2/5] Add VSX support for core-files
- From: Luis Machado <luisgpm at linux dot vnet dot ibm dot com>
- To: Ulrich Weigand <uweigand at de dot ibm dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 15 Aug 2008 12:26:20 -0300
- Subject: Re: [PATCH-ppc 2/5] Add VSX support for core-files
- References: <200808141951.m7EJpjWM025421@d12av02.megacenter.de.ibm.com>
- Reply-to: luisgpm at linux dot vnet dot ibm dot com
On Thu, 2008-08-14 at 21:51 +0200, Ulrich Weigand wrote:
> Luis Machado wrote:
>
> > 2008-07-25 Luis Machado <luisgpm@br.ibm.com>
> >
> > * ppc-linux-tdep.c (ppc_linux_regset_sections): Add new ".reg-ppc-vsx" field.
> > (ppc32_linux_vsxregset): New 32-bit VSX-enabled regset.
> > (ppc_linux_regset_from_core_section): Handle VSX core section.
> > (ppc_linux_core_read_description): Support VSX-enabled core files.
> >
> > * corelow.c (get_core_register_section): Support VSX-enabled
> > core files.
>
> This is OK.
>
> > Index: gdb/corelow.c
> > ===================================================================
> > --- gdb.orig/corelow.c 2008-07-23 09:28:09.000000000 -0700
> > +++ gdb/corelow.c 2008-07-23 09:31:44.000000000 -0700
> > @@ -499,6 +499,8 @@
> > ".reg-xfp", 3, "extended floating-point", 0);
> > get_core_register_section (regcache,
> > ".reg-ppc-vmx", 3, "ppc Altivec", 0);
> > + get_core_register_section (regcache,
> > + ".reg-ppc-vsx", 4, "POWER7 VSX", 0);
>
> It would be nice if we could convert this to a loop using the
> gdbarch_core_regset_sections list at some point ...
>
> Bye,
> Ulrich
Checked in.
Luis