This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [MI non-stop 05/11, RFA] -exec-continue/-exec-interrupt --all
- From: Daniel Jacobowitz <drow at false dot org>
- To: Vladimir Prus <vladimir at codesourcery dot com>, gdb-patches at sources dot redhat dot com
- Date: Sun, 13 Jul 2008 00:24:47 -0400
- Subject: Re: [MI non-stop 05/11, RFA] -exec-continue/-exec-interrupt --all
- References: <200806282045.39438.vladimir@codesourcery.com> <20080711133434.GA2651@caradoc.them.org>
On Fri, Jul 11, 2008 at 09:34:34AM -0400, Daniel Jacobowitz wrote:
> > @@ -177,8 +177,12 @@ mi_cmd_exec_return (char *command, char **argv, int argc)
> > void
> > mi_cmd_exec_continue (char *command, char **argv, int argc)
> > {
> > - /* FIXME: Should call a libgdb function, not a cli wrapper. */
> > - return mi_execute_async_cli_command ("continue", argv, argc);
> > + if (argc == 0)
> > + continue_1 (0);
> > + else if (argc == 1 && strcmp (argv[0], "--all") == 0)
> > + continue_1 (1);
> > + else
> > + error ("Usage: -exec-continue [--all]");
> > }
> >
> > /* Interrupt the execution of the target. Note how we must play around
>
> I suggest you use mi_getopt instead, for consistency.
Did you notice this comment?
Also, please remember to post the version of patches that you check
in.
--
Daniel Jacobowitz
CodeSourcery