Re: [PATCH] PPC - Stepping off breakpoints in non-stop mode

[Luis Machado <luisgpm at linux dot vnet dot ibm dot com>]

Hi Jonathan,

Is this an embedded target?

> Unfortunately this fails to build due to this warning (in combination with
> -Werror):
> .../rs6000-tdep.c: In function âppc_displaced_step_fixupâ:
> .../rs6000-tdep.c:885: warning: passing argument 3 of
> âregcache_cooked_read_unsignedâ from incompatible pointer type
> make[2]: *** [rs6000-tdep.o] Error 1
> 
> This is because in the following line, current_pc is CORE_ADDR, but
> regcache_cooked_read_unsigned's last arg is meant to be a ULONGEST *.
> 
> +      regcache_cooked_read_unsigned (regs, gdbarch_pc_regnum (gdbarch),
> +				      &current_pc);
> 
> I was thinking of just casting it, but in fact would it be better to be
> calling regcache_read_pc() here as well as regcache_write_pc() in the rest
> of the patch when operating on the pc? From earlier in this thread, there
> was a little discussion about address sizes, so I thought I'd best ask
> before submitting a patch, as there could be portability implications and
> it might have been done this way for a reason.
> 
> Jifl