This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA/commit] Fix SP register unwinding on alpha-tru64


Thanks for the feedback, Ulrich.

> Hmm, in alpha-mdebug-tdep.c this is now implemented as:
> 
>   /* The stack pointer of the previous frame is computed by popping
>      the current stack frame.  */
>   if (!trad_frame_addr_p (info->saved_regs, ALPHA_SP_REGNUM))
>    trad_frame_set_value (info->saved_regs, ALPHA_SP_REGNUM, vfp);
> 
> at the end of alpha_mdebug_frame_unwind_cache ...
> 
> Should the two files use the same method here?

I agree. I think that the mdebug approach is a little cleaner, so
how about the attached?

2008-05-30  Joel Brobecker  <brobecker@adacore.com>

        * alpha-tdep.c (alpha_heuristic_frame_unwind_cache): Set
        the trad-frame register value for the SP register.

Tested on alpha-tru64 with the AdaCore testsuite.

-- 
Joel

Attachment: alpha-tdep.c.diff
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]